fix(openai-adapter): add reasoning_content and handle max_completion_…#10478
Closed
BurakBebek1 wants to merge 1 commit intocontinuedev:mainfrom
Closed
fix(openai-adapter): add reasoning_content and handle max_completion_…#10478BurakBebek1 wants to merge 1 commit intocontinuedev:mainfrom
BurakBebek1 wants to merge 1 commit intocontinuedev:mainfrom
Conversation
…tokens for DeepSeek Reasoner
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
@BurakBebek1 there was a fix for the missing reasoning content merged here #11290 It looks like you also fixed max_completion_tokens, could you potentially remove the reasoning_content part and keep the max_completion_tokens fix? Or let me know if you think the |
3 tasks
Contributor
|
@BurakBebek1 rushed this one in on #11889. I added you as coauthor on the commit. Appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a specific compatibility issue between the Continue OpenAI adapter and DeepSeek Reasoner (R1) models.
The Problem
The Solution
Fixes #10475
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
modifyChatBodycorrectly injectsreasoning_contentand maps token parameters specifically for DeepSeek.npm run buildpassed successfully inpackages/openai-adapters.Summary by cubic
Fixes DeepSeek Reasoner (R1) compatibility in the OpenAI adapter by adding missing reasoning_content and mapping max_tokens to max_completion_tokens to prevent 400 errors.
Written for commit 62b4e77. Summary will update on new commits.